resolved 56 of the 94 errors #920
Conversation
for more information, see https://pre-commit.ci
|
Build failed. ❌ pre-commit FAILURE in 3m 47s |
| raise NotImplementedError() | ||
|
|
||
| @indirect(ForgejoIssue.get_list) | ||
| # type: ignore |
There was a problem hiding this comment.
| # type: ignore | |
| # type: ignore[empty-body] |
There was a problem hiding this comment.
Same applies elsewhere. It's better to pass an explicit error code when to type: ignore pragmas, but maybe it doesn't matter so much here.
| @property | ||
| def created_at(self) -> datetime.datetime: | ||
| return None | ||
| return datetime.datetime.now |
There was a problem hiding this comment.
It looks like you forgot parentheses. This returns a function object, not a datetime. In any case, I'm not sure returning the current time is right here. Probably better to change the type signature to datetime.datetime | None here and in the base class to reflect that some implementations don't provide this information.
| if ogr_pagure.PagureProject is None: | ||
| _source_project = "" | ||
| _source_project: "ogr_pagure.PagureProject" |
There was a problem hiding this comment.
| if ogr_pagure.PagureProject is None: | |
| _source_project = "" | |
| _source_project: "ogr_pagure.PagureProject" | |
| _source_project: Optional[ogr_pagure.PagureProject] |
2 participants
TODO:
packit/packit.dev.Fixes
Related to
Merge before/after
RELEASE NOTES BEGIN
Packit now supports automatic ordering of ☕ after all checks pass.
RELEASE NOTES END
